Breaking: Remove YGConfigGetInstanceCount#1370
Closed
NickGerleman wants to merge 4 commits intofacebook:mainfrom
Closed
Breaking: Remove YGConfigGetInstanceCount#1370NickGerleman wants to merge 4 commits intofacebook:mainfrom
NickGerleman wants to merge 4 commits intofacebook:mainfrom
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 6d6dfec415bef9d2fc37e4ac776dfe62868b4839
NickGerleman
force-pushed
the
export-D49131207
branch
from
b205f95 to
a29320f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 243b3780e7a2fdf8b63ccdd67fc1b10b39198d67
NickGerleman
force-pushed
the
export-D49131207
branch
from
a29320f to
552e453
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: f62a6d802f2da6ee6196043cdc16392d23ad67cb
NickGerleman
force-pushed
the
export-D49131207
branch
from
552e453 to
54679f0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 10, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Differential Revision: D49131207 fbshipit-source-id: 80ae77ab6312a86eaa3046061406318d12a2d6c2
NickGerleman
force-pushed
the
export-D49131207
branch
from
54679f0 to
c94515d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 6e59be2a10d9de4c48ffc9174fd075d3075d1e53
NickGerleman
force-pushed
the
export-D49131207
branch
from
c94515d to
7963e7f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: fa732ba593e6d1bc97c0274a73b03626d25cd556
NickGerleman
force-pushed
the
export-D49131207
branch
from
7963e7f to
b5edb4f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 1e95a2e55076c5916d5df45e65ee873e7a7afe4a
NickGerleman
force-pushed
the
export-D49131207
branch
from
b5edb4f to
ce469e8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 12, 2023
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 80068755141b0c9e2bb005d336020d8783b4fb01
NickGerleman
force-pushed
the
export-D49131207
branch
from
ce469e8 to
fb92cf2
Compare
Summary: This changes public Yoga API to in more places accept const structures where before they required mutable ones. This tries to avoid more breaking changes yet, e.g. changing callbacks to require clients do not modify nodes when they are passed for logging. We also don't have const variants for returning child structures which would allow mutation of dependencies of the const object. These would need new names under the public API, since we do not have operator overloading in C. Differential Revision: D49130412 fbshipit-source-id: ee02eeb1d9e6fcb299da1655a791dd599350c67c
Summary: Pull Request resolved: facebook#1369 X-link: facebook/react-native#39370 This fixes const-correctness of callbacks (e.g. not letting a logger function modify nodes during layout). This helps us to continue to fix const-correctness issues inside of Yoga. This change is breaking to the public API, since it requires a change in signature passed to Yoga. Changelog: [Internal] Differential Revision: https://internalfb.com/D49130714 fbshipit-source-id: a01ca31e172350fd62e04350f99e412035a70b61
Summary: Yoga's public API exposes indices most often as `uint32_t`, with exception of clone callbacks which are `int32_t`. Yoga internally represents these indices as `size_t` when dealing with the child vector, and this is the true index. This changes the API to consistently be `size_t`. This should not be breaking for most users, but will cause breaks where: 1. Users set a clone node callback (I think this should be rare. RN uses it, but only because it relies on a separate private API). 2. Callers of `YGNodeGetChildCount()` are assigning to an int with less width than `size_t` and have strong warnings enabled. 3. Using a newer Yoga binary with older source, since we are not preserving ABI compatibility (Yoga in general does not aim to be ABI stable between major versions, only ABI safe for a given set of sources). Differential Revision: D49130914 fbshipit-source-id: 08d1d7dfd883c4adcc736ed38b7f2ac1482140a6
Summary: Pull Request resolved: facebook#1370 X-link: facebook/react-native#39369 This was added in facebook#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 4e0f15068a10f95597e3421d3e7ad84d840eec94
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49131207 |
NickGerleman
force-pushed
the
export-D49131207
branch
from
fb92cf2 to
57a589e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: facebook#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 36cf4caebaba498a806c0aeea853b54f18077832
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1370 X-link: facebook/react-native#39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 58537ed635ed455ff065471bdf77061a4bf826f4
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 12, 2023
Summary: X-link: facebook/yoga#1370 Pull Request resolved: #39369 This was added in facebook/yoga#497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree. This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed. Reviewed By: rshest Differential Revision: D49131207 fbshipit-source-id: 58537ed635ed455ff065471bdf77061a4bf826f4
Contributor
|
This pull request has been merged in a2d3fc6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This was added in #497 specifically for tests related to memory leaks in the C# bindings to count how often YGConfigFree.
This is the wrong layer for this check, we don't have officially supported C# bindings anymore, and this API is not safe when Yoga runs on multiple threads. This removes it, similar to a global node instance count that was also previously removed.
Differential Revision: D49131207